Open
Conversation
ghost
reviewed
Sep 9, 2020
| const randomNumber = Math.floor(Math.random()*sentences.length); | ||
| console.log(sentences[randomNumber]) | ||
| } | ||
| } |
There was a problem hiding this comment.
nice start here! if you like we can talk through this, it's definitely a lot to think through!
ghost
reviewed
Sep 9, 2020
| } else { | ||
| console.log(i) | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
you're really close here! it's important to remember that the most specific condition (checking against 3 AND 5 at the same time) should happen first. otherwise, a number like 15 will get caught in the FIRST condition it meets (in this case, checking against 3 in line 40).
|
nice work overall! it's clear you've got a good grasp on loops. still a few things we can work on as far as breaking down problems logically and translating that logic into code, but I'm marking this complete as the loops themselves are working really well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.